feat/block-chat-phrases: Add blocked phrases feature #514
Conversation
|
Nice! That's been a highly requested feature, will have a look sometime today 👍 To fix CI issues simply run |
There was a problem hiding this comment.
I believe this could be heavily simplified with a few steps
- Compound everything into the highlights system. Instead of duplicating it, just add a mode property, or boolean flag, to define whether it's a highlight or filter
- You can add an argument to
useChatHighlights, to define the mode. - Store filters in a different config key
- Generalize the component for the interface used between this and highlights
|
@AnatoleAM Now a Highlight has a Blocked toggle from where it toggles it into a new config set PS. |
This needs a general refactor of the settings system. It's currently implemented in a way which does not allow non-shallow reactive updates to be detected. Hence why a |
|
@AnatoleAM PR updated with the requested changes and the terminology is now "Ignores" |
There was a problem hiding this comment.
Close, but needs some improvement on the UX side
- Split ignores into a new setting category
- Instead of adding
isIgnoredon highlights, pass an argument touseChatHighlightsto define whether to use ignore or highlight mode - Define the config key used based on the mode passed to the composable
|
@AnatoleAM now the Ignores are in Chat > Ignores |
|
@AnatoleAM added now a wrapper for ignores |
…on into feat/block-chat-phrases
|
I resolved merge conflicts, but not sure what the linter is complaining about now |
|
Closing as stale |
This will add a new section under Chat settings where you can add blocked phrases that you don't want to see in chat. It looks and works similarly to highlights but the other way around.
Closes #403